ajantha-bhat commented on code in PR #11326: URL: https://github.com/apache/iceberg/pull/11326#discussion_r1802441910
########## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/BaseCatalog.java: ########## @@ -30,12 +30,14 @@ import org.apache.spark.sql.connector.iceberg.catalog.ProcedureCatalog; import org.apache.spark.sql.util.CaseInsensitiveStringMap; -abstract class BaseCatalog +public abstract class BaseCatalog Review Comment: Wanted to use `BaseCatalog` instead of `TableCatalog` to support views in `BaseProcedure`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
