findepi commented on code in PR #10494: URL: https://github.com/apache/iceberg/pull/10494#discussion_r1802050253
########## core/src/main/java/org/apache/iceberg/io/ContentCache.java: ########## @@ -147,10 +147,23 @@ public InputFile tryCache(InputFile input) { return input; } + /** + * Invalidate the cache entry for the given key. + * + * <p>Note: if there is ongoing load, this is a blocking operation, i.e. it will wait for the load + * to complete before invalidating the entry. + */ public void invalidate(String key) { cache.invalidate(key); } + /** + * @deprecated since 1.6.0, will be removed in 1.7.0; This method does only best-effort Review Comment: good catch, thanks! see https://github.com/apache/iceberg/pull/11325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org