nastra commented on code in PR #11292:
URL: https://github.com/apache/iceberg/pull/11292#discussion_r1796754363


##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedColumnIterator.java:
##########
@@ -214,20 +214,6 @@ protected int nextBatchOf(
     }
   }
 
-  public class FixedWidthTypeBinaryBatchReader extends BatchReader {

Review Comment:
   I don't think we can just remove this. We should add a deprecation message 
(`@deprecated since 1.7.0, will be removed in 1.8.0`) here and to 
`fixedWidthTypeBinaryBatchReader`as it's possible that consumers of Iceberg 
could use this. See also #3249 on how we did the deprecation and #7987 later 
removed this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to