nastra commented on code in PR #11281:
URL: https://github.com/apache/iceberg/pull/11281#discussion_r1796630239


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3103,6 +3141,32 @@ components:
         uuid:
           type: string
 
+    Credential:
+      type: object
+      required:
+        - prefix
+        - config
+      properties:
+        prefix:
+          type: string
+          description: Indicates a storage location prefix where the 
credential is relevant. Clients should choose the most
+            specific prefix if several credentials of the same type are 
available.
+        config:

Review Comment:
   It could make sense to have a `expires-at-ms` field here, but I believe it's 
better if this isn't part of the OpenAPI spec and be rather specific to the 
underlying storage provider. That being said, I think it should be documented 
along with other properties related to that storage provider. The underlying 
refresh handler for the given storage provider can still mandate that the 
server sends the expiration field for a vended credential



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to