amogh-jahagirdar commented on code in PR #11261:
URL: https://github.com/apache/iceberg/pull/11261#discussion_r1796430454


##########
api/src/main/java/org/apache/iceberg/expressions/StrictMetricsEvaluator.java:
##########
@@ -60,7 +57,6 @@ public StrictMetricsEvaluator(Schema schema, Expression 
unbound) {
   }
 
   public StrictMetricsEvaluator(Schema schema, Expression unbound, boolean 
caseSensitive) {
-    this.schema = schema;

Review Comment:
   Ah nvm, I see that it was only used for the purpose of resolving if a field 
was nested or not



##########
api/src/main/java/org/apache/iceberg/expressions/StrictMetricsEvaluator.java:
##########
@@ -60,7 +57,6 @@ public StrictMetricsEvaluator(Schema schema, Expression 
unbound) {
   }
 
   public StrictMetricsEvaluator(Schema schema, Expression unbound, boolean 
caseSensitive) {
-    this.schema = schema;

Review Comment:
   Why are we removing this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to