RussellSpitzer commented on code in PR #11240: URL: https://github.com/apache/iceberg/pull/11240#discussion_r1795813873
########## format/spec.md: ########## @@ -604,7 +612,7 @@ Scans are planned by reading the manifest files for the current snapshot. Delete Manifests that contain no matching files, determined using either file counts or partition summaries, may be skipped. -For each manifest, scan predicates, which filter data rows, are converted to partition predicates, which filter data and delete files. These partition predicates are used to select the data and delete files in the manifest. This conversion uses the partition spec used to write the manifest file. +For each manifest, scan predicates, which filter data rows, are converted to partition predicates, which filter partition tuples. These partition predicates are used to select data files, delete files, and deletion vector metadata relevant to the scan. This conversion uses the partition spec used to write the manifest file. Review Comment: ```suggestion For each manifest, scan predicates, which filter data rows, are converted to partition predicates, which filter partition tuples. These partition predicates are used to select relevant data files, delete files, and deletion vector metadata. These conversions use the partition spec which was used to write the manifest file regardless of the current partition spec. ``` I added a bunch of changes in this suggestion, some of which aren't critical to this PR but I felt like the wording could be improved. Tense matching/plural matching -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
