singhpk234 commented on code in PR #11273: URL: https://github.com/apache/iceberg/pull/11273#discussion_r1794359228
########## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatchQueryScan.java: ########## @@ -158,6 +163,26 @@ public void filter(Predicate[] predicates) { } } + protected Map<String, DeleteFileSet> dataToFileScopedDeletes() { Review Comment: [a bit orthogonal] can we put an estimate on the size of the HM ? if it goes very high it can fail the query in that case should we let the query fail ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org