nastra commented on code in PR #11195: URL: https://github.com/apache/iceberg/pull/11195#discussion_r1778254044
########## api/src/main/java/org/apache/iceberg/util/DataFileSet.java: ########## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.util; + +import java.util.Objects; +import org.apache.iceberg.DataFile; +import org.apache.iceberg.relocated.com.google.common.collect.Iterables; +import org.apache.iceberg.relocated.com.google.common.collect.Sets; +import org.apache.iceberg.types.Comparators; + +public class DataFileSet extends WrapperSet<DataFile> { + private static final ThreadLocal<DataFileWrapper> WRAPPERS = + ThreadLocal.withInitial(() -> DataFileWrapper.wrap(null)); + + protected DataFileSet(Iterable<Wrapper<DataFile>> wrappers) { + super(wrappers); + } + + public static DataFileSet empty() { + return new DataFileSet(Sets.newLinkedHashSet()); + } + + public static DataFileSet of(Iterable<DataFile> iterable) { + return new DataFileSet( + Sets.newLinkedHashSet(Iterables.transform(iterable, DataFileWrapper::wrap))); + } + + @Override + protected Wrapper<DataFile> wrapper() { + return WRAPPERS.get(); + } + + @Override + protected Wrapper<DataFile> wrap(DataFile dataFile) { + return DataFileWrapper.wrap(dataFile); + } + + @Override + protected boolean isInstance(Object obj) { + return obj instanceof DataFile; + } + + private static class DataFileWrapper implements Wrapper<DataFile> { + private DataFile file; + + private DataFileWrapper(DataFile file) { + this.file = file; + } + + private static DataFileWrapper wrap(DataFile dataFile) { + return new DataFileWrapper(dataFile); + } + + @Override + public DataFile get() { + return file; + } + + @Override + public Wrapper<DataFile> set(DataFile dataFile) { + this.file = dataFile; + return this; + } + + @Override + public boolean equals(Object o) { + if (this == o) { + return true; + } + + if (!(o instanceof DataFileWrapper)) { + return false; + } + + DataFileWrapper that = (DataFileWrapper) o; + if (null == file && null == that.file) { Review Comment: I don't think we should allow nulls in the set itself, but the Wrapper's value could be `null` and so it's better to be defensive here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
