alex-kar opened a new pull request, #156: URL: https://github.com/apache/iceberg-go/pull/156
Handle config file `.iceberg-go.yaml` in the home directory. Closes #62 @zeroshade I noticed that `--catalog` has different functionality compare to pyiceberg cli, where it defines catalog name to be loaded from configuration file. iceberg-go - `--catalog` - catalog type. pyiceberg `--catalog` - catalog name to load from configuration file. Because of this reason, currently it can load only `default` catalog. Another note is that `docopt` throw's exception when struct has some non default values. https://github.com/docopt/docopt.go/issues/55 Because of this limitation, I can't first parse configuration file and then provide the same struct to `docopt` to ensure the correct precedence. instead I added this manual mapping: ``` func mergeConf(fileConf *config.CatalogConfig, resConfig *Config) { if len(resConfig.Catalog) == 0 { resConfig.Catalog = fileConf.Catalog } ... } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
