kevinjqliu commented on PR #1208:
URL: https://github.com/apache/iceberg-python/pull/1208#issuecomment-2378222143

   > Basically, Spark stores day transformed partition values incorrectly in 
the metadata
   
   Thats an interesting find... The core Iceberg library is using `DateType` as 
the Result Type for DayTransform
   
https://github.com/apache/iceberg/blame/main/api/src/main/java/org/apache/iceberg/transforms/Days.java#L47
   
   In fact, its the only "time-based" transforms which uses this
   
https://grep.app/search?q=getResultType&filter[repo][0]=apache/iceberg&filter[path][0]=api/src/main/java/org/apache/iceberg/
   
   Let me bring this up in the devlist. In the meantime, I think we can either
   1. Put back `DateType` as the result type for Day Transform to match the 
behavior
   2. Fix it in the Partitions metadata table as a workaround and link an issue 
to fix forward
   
   I don't want to a workaround in the tests as it will become difficult to 
maintain. WYDT? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to