RussellSpitzer commented on code in PR #10943:
URL: https://github.com/apache/iceberg/pull/10943#discussion_r1777429830


##########
parquet/src/main/java/org/apache/iceberg/parquet/VectorizedParquetReader.java:
##########
@@ -49,6 +49,7 @@ public class VectorizedParquetReader<T> extends 
CloseableGroup implements Closea
   private final boolean caseSensitive;
   private final int batchSize;
   private final NameMapping nameMapping;
+  private int pushedLimit = -1;
 
   public VectorizedParquetReader(

Review Comment:
   I think we should probably just add another constructor so we don't need to 
rewrite all the other use cases. I think we should also have pushedLimit just 
be an Integer so we can pass null. I don't like magic numbers (even -1).
   
   So two suggestions for me
   ```java
   // Keep
   Foo (x,y,z)
   // Add
   Foo (x,y,z,pushedLimit)
   ```
   
   And 
   ```java
   Integer pushedLimit = null
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to