slessard commented on code in PR #10953:
URL: https://github.com/apache/iceberg/pull/10953#discussion_r1777418703
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java:
##########
@@ -128,7 +130,8 @@ public static VectorHolder dummyHolder(int numRows) {
}
public boolean isDummy() {
- return vector == null;
+ boolean isDummy = (vector == null) || vector instanceof NullVector;
+ return isDummy;
Review Comment:
fixed
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java:
##########
@@ -128,7 +130,8 @@ public static VectorHolder dummyHolder(int numRows) {
}
public boolean isDummy() {
- return vector == null;
+ boolean isDummy = (vector == null) || vector instanceof NullVector;
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
