slessard commented on code in PR #10953:
URL: https://github.com/apache/iceberg/pull/10953#discussion_r1776421822
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java:
##########
@@ -140,12 +141,18 @@ public static class ConstantVectorHolder<T> extends
VectorHolder {
private final int numRows;
public ConstantVectorHolder(int numRows) {
+ super(new NullVector("_dummy_", numRows), null, new
NullabilityHolder(numRows));
+ nullabilityHolder().setNulls(0, numRows);
this.numRows = numRows;
this.constantValue = null;
}
public ConstantVectorHolder(Types.NestedField icebergField, int numRows, T
constantValue) {
- super(icebergField);
+ super(
+ new NullVector(icebergField.name(), numRows),
Review Comment:
@nastra There are many test classes that now contain failures. Here's a
good example of just one of the Spark test classes that fails. Most of the
tests in TestSparkDataWrite are failing.
```
org.opentest4j.AssertionFailedError: [Result rows should match]
expected: [{"id"=1,"data"="a"}, {"id"=2,"data"="b"}, {"id"=3,"data"="c"}]
but was: [{"id"=1,"data"="null"}, {"id"=2,"data"="null"},
{"id"=3,"data"="null"}]
at
org.apache.iceberg.spark.source.TestSparkDataWrite.testBasicWrite(TestSparkDataWrite.java:145)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
