kevinjqliu commented on code in PR #1208:
URL: https://github.com/apache/iceberg-python/pull/1208#discussion_r1776111931
##########
pyiceberg/transforms.py:
##########
@@ -517,9 +517,6 @@ def day_func(v: Any) -> int:
def can_transform(self, source: IcebergType) -> bool:
return isinstance(source, (DateType, TimestampType, TimestamptzType))
- def result_type(self, source: IcebergType) -> IcebergType:
- return DateType()
-
Review Comment:
nit: can we be explicit here and do
```
def result_type(self, source: IcebergType) -> IntegerType:
return IntegerType()
```
##########
pyiceberg/transforms.py:
##########
@@ -491,7 +491,7 @@ class DayTransform(TimeTransform[S]):
"""Transforms a datetime value into a day value.
Example:
- >>> transform = MonthTransform()
+ >>> transform = DayTransform()
Review Comment:
ty!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
