aokolnychyi commented on code in PR #11199:
URL: https://github.com/apache/iceberg/pull/11199#discussion_r1776090858
##########
core/src/main/java/org/apache/iceberg/util/ContentFileUtil.java:
##########
@@ -49,7 +50,21 @@ public static <F extends ContentFile<K>, K> K copy(
}
}
+ /**
+ * @deprecated since 1.7.0, will be removed in 2.0.0; use {@link
+ * #referencedDataFileLocation(DeleteFile)} instead.
+ */
+ @Deprecated
public static CharSequence referencedDataFile(DeleteFile deleteFile) {
+ return referencedLocation(deleteFile);
+ }
+
+ public static String referencedDataFileLocation(DeleteFile deleteFile) {
+ CharBuffer location = referencedLocation(deleteFile);
+ return location != null ? location.toString() : null;
+ }
+
+ private static <T> T referencedLocation(DeleteFile deleteFile) {
Review Comment:
Is there value in a new method? Why not simply call `referencedDataFile` in
the new method?
```
public static String referencedDataFileLocation(DeleteFile deleteFile) {
CharSequence location = referencedDataFile(deleteFile);
return location != null ? location.toString() : null;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
