rodmeneses commented on PR #10179: URL: https://github.com/apache/iceberg/pull/10179#issuecomment-2374304971
> @rodmeneses: I would follow the steps taken by the IcebergTableSource, but instead of `createFLIP27Stream` and `table.exec.iceberg.use-flip27-source` we should find a better name. I remember that we discussed that the choice of the parameters were not the best one. Maybe even V2 could be better in this case. WDYT @stevenzwu ? Thanks @pvary . That sounds reasonable. Hi @arkadius. When you said that "everything works", what did you mean? Did you mean that all tests passed? I might be missing something, but I cannot find unit tests covering `IcebergTableSink`. So maybe now it's a good opportunity to also write unit test to cover all these code... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
