c-thiel commented on code in PR #615:
URL: https://github.com/apache/iceberg-rust/pull/615#discussion_r1774975537
##########
crates/iceberg/src/spec/schema.rs:
##########
@@ -86,6 +87,16 @@ impl SchemaBuilder {
self
}
+ /// Reassign all field-ids (nested) on build.
+ /// If `start_from` is provided, it will start reassigning from that id
(inclusive).
+ /// If not provided, it will start from 0.
+ ///
+ /// All specified aliases and identifier fields will be updated to the new
field-ids.
+ pub fn with_reassigned_field_ids(mut self, start_from: Option<i32>) ->
Self {
+ self.reassign_field_ids_from = Some(start_from.unwrap_or(0));
Review Comment:
Both good points, fixed in the latest commit.
Its `dead_code` for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
