aokolnychyi commented on code in PR #11203:
URL: https://github.com/apache/iceberg/pull/11203#discussion_r1774073091
##########
core/src/main/java/org/apache/iceberg/io/DeleteWriteResult.java:
##########
@@ -32,25 +32,39 @@
public class DeleteWriteResult {
private final List<DeleteFile> deleteFiles;
private final CharSequenceSet referencedDataFiles;
+ private final List<DeleteFile> rewrittenDeleteFiles;
public DeleteWriteResult(DeleteFile deleteFile) {
this.deleteFiles = Collections.singletonList(deleteFile);
this.referencedDataFiles = CharSequenceSet.empty();
+ this.rewrittenDeleteFiles = Collections.emptyList();
}
public DeleteWriteResult(DeleteFile deleteFile, CharSequenceSet
referencedDataFiles) {
this.deleteFiles = Collections.singletonList(deleteFile);
this.referencedDataFiles = referencedDataFiles;
+ this.rewrittenDeleteFiles = Collections.emptyList();
}
public DeleteWriteResult(List<DeleteFile> deleteFiles) {
this.deleteFiles = deleteFiles;
this.referencedDataFiles = CharSequenceSet.empty();
+ this.rewrittenDeleteFiles = Collections.emptyList();
}
public DeleteWriteResult(List<DeleteFile> deleteFiles, CharSequenceSet
referencedDataFiles) {
this.deleteFiles = deleteFiles;
this.referencedDataFiles = referencedDataFiles;
+ this.rewrittenDeleteFiles = Collections.emptyList();
+ }
+
+ public DeleteWriteResult(
Review Comment:
If I had to implement `DeleteWriteResult` now, I'd add a builder like in
`WriteResult`. That said, we already have 4 public constructors that we will
have to maintain. I am not sure adding a builder would help now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
