rahil-c commented on PR #11180: URL: https://github.com/apache/iceberg/pull/11180#issuecomment-2368649315
> Thanks @rahil-c for kicking off the implementation! I wonder what others think but IMO this can be combined with serializer implementations that get registered in `RESTSerializers`. Then we can have more robust tests which exercise all the validation logic in the model. > can you also please add respective JSON parser(s) with tests for those parser(s) as those request/response classes won't be serialized/deserialized Thanks @amogh-jahagirdar and @nastra for revieiwing, will follow up on this pr with serializers, parsers, and the tests for them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
