nastra commented on code in PR #11148:
URL: https://github.com/apache/iceberg/pull/11148#discussion_r1764428159
##########
core/src/main/java/org/apache/iceberg/rest/responses/LoadTableResponse.java:
##########
@@ -61,7 +62,12 @@ public String metadataLocation() {
}
public TableMetadata tableMetadata() {
- return
TableMetadata.buildFrom(metadata).withMetadataLocation(metadataLocation).build();
+ if (null == metadataWithLocation) {
Review Comment:
we were rebuilding the metadata on every call to `tableMetadata()` which was
required when java reflection was used for JSON deserialiazion. However, now
this isn't needed anymore, so we can compute the metadata with the location
only once
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
