bryanck commented on code in PR #11075:
URL: https://github.com/apache/iceberg/pull/11075#discussion_r1764246337
##########
kafka-connect/kafka-connect-runtime/src/integration/java/org/apache/iceberg/connect/TestContext.java:
##########
@@ -51,6 +52,7 @@ public class TestContext {
private TestContext() {
ComposeContainer container =
new ComposeContainer(new File("./docker/docker-compose.yml"))
+ .withStartupTimeout(Duration.ofMinutes(2))
Review Comment:
I moved the context init to `BeforeAll` so the test will fail at
initialization, which should be more clear.
##########
kafka-connect/kafka-connect-runtime/src/integration/java/org/apache/iceberg/connect/TestContext.java:
##########
@@ -51,6 +52,7 @@ public class TestContext {
private TestContext() {
ComposeContainer container =
new ComposeContainer(new File("./docker/docker-compose.yml"))
+ .withStartupTimeout(Duration.ofMinutes(2))
Review Comment:
I moved the context init to `@BeforeAll` so the test will fail at
initialization, which should be more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
