RussellSpitzer commented on code in PR #10774:
URL: https://github.com/apache/iceberg/pull/10774#discussion_r1763468390
##########
spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSqlExtensionsAstBuilder.scala:
##########
@@ -226,11 +226,13 @@ class IcebergSqlExtensionsAstBuilder(delegate:
ParserInterface) extends IcebergS
}
val distributionMode = if (distributionSpec != null) {
- DistributionMode.HASH
- } else if (orderingSpec.UNORDERED != null || orderingSpec.LOCALLY != null)
{
- DistributionMode.NONE
+ Some(DistributionMode.HASH)
+ } else if (orderingSpec.UNORDERED != null) {
Review Comment:
I believe this function is used by other pieces of code. Specifically the
Create statements where RANGE is set if there is an ordering. Maybe it makes
sense to separate it out into a Distribution and ordering for ALTER and one for
CREATE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
