ggershinsky commented on code in PR #7770:
URL: https://github.com/apache/iceberg/pull/7770#discussion_r1762446655
##########
core/src/main/java/org/apache/iceberg/CatalogProperties.java:
##########
@@ -160,4 +160,10 @@ private CatalogProperties() {}
public static final String ENCRYPTION_KMS_TYPE = "encryption.kms-type";
public static final String ENCRYPTION_KMS_IMPL = "encryption.kms-impl";
+ public static final String WRITER_KEK_TIMEOUT_SEC =
"encryption.kek-timeout-sec";
Review Comment:
Since we have a reasonably well defined value of this parameter in the NIST
spec, maybe we don't need to make it configurable in an initial version of
table encryption. This parameter is also not easy to explain. So I'll remove
this from the `CatalogProperties` for now. If, for some reason, a requirement
comes later to make this configurable, we can this back, with a proper name and
documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
