wypoon commented on code in PR #10935:
URL: https://github.com/apache/iceberg/pull/10935#discussion_r1762263665
##########
core/src/test/java/org/apache/iceberg/TestBaseIncrementalChangelogScan.java:
##########
@@ -132,6 +131,139 @@ public void testFileDeletes() {
assertThat(t1.existingDeletes()).as("Must be no deletes").isEmpty();
}
+ @TestTemplate
+ public void testPositionDeletes() {
Review Comment:
Thank you for the review.
I consolidated `testPositionDeletes`, `testEqualityDeletes` and
`testMixOfPositionAndEqualityDeletes` into one test to reduce repetition as
well as to test a scan with multiple snapshots. I also added tests for scan
tasks with existing deletes.
In the process, I discovered a bug in some edge cases and need to work on a
fix before I push an update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
