dimas-b commented on code in PR #10722:
URL: https://github.com/apache/iceberg/pull/10722#discussion_r1761277139
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3103,6 +3103,82 @@ components:
uuid:
type: string
+ ADLSCredentials:
+ type: object
+ allOf:
+ - $ref: '#/components/schemas/Credentials'
+ required:
+ - type
+ - sas-token
+ - expires-at-ms
+ properties:
+ type:
+ type: string
+ enum: [ "adls" ]
+ sas-token:
+ type: string
+ expires-at-ms:
+ type: integer
+ format: int64
+ description: The epoch millis at which the given token expires
Review Comment:
nit: sorry, but "the epoch" is still not precise :) Would you mind
mentioning a specific point in time (as in javadoc of
`System.currentTimeMillis()`?... i.e. `Milliseconds since January 1, 1970 UTC`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
