sungwy commented on issue #1148: URL: https://github.com/apache/iceberg-python/issues/1148#issuecomment-2351786822
Hi @isc-patrick - thank you for putting up the PR and, sharing the related Java link. I thought about this a lot more in light of @Fokko ’s review comment on https://github.com/apache/iceberg-python/pull/1155 and I think introducing the flag to disable the table creation DDL on initialization (rather than removing `_ensure_tables_exist` as I had originally suggested) would be best to resolve this issue for now. If as you noted, the permission to run `create_all` with the checkfirst=True varies between dialects, this change may result in a backward incompatible change for some sql dialects. If any initialization relies on `CREATE TABLE` permissions to run `create_all` it will begin failing with this change. The disable flag that you suggested will keep the existing behavior for all applications. The different backends that are current not supported, because the current list of exceptions don’t catch the specific exception thrown by the DB backend, can enable the flag to successfully initialize the catalog. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
