felixscherz commented on code in PR #1176:
URL: https://github.com/apache/iceberg-python/pull/1176#discussion_r1759784424
##########
tests/integration/test_partition_evolution.py:
##########
@@ -152,6 +201,36 @@ def test_multiple_adds(catalog: Catalog) -> None:
)
[email protected]
[email protected]("catalog",
[pytest.lazy_fixture("session_catalog_hive"),
pytest.lazy_fixture("session_catalog")])
+def test_add_void(catalog: Catalog, table_schema_simple: Schema) -> None:
+ simple_table = _create_table_with_schema(catalog, table_schema_simple, "1")
+ simple_table.update_spec().add_field("foo", VoidTransform(),
"void_transform").commit()
+ _validate_new_partition_fields(
+ simple_table, 1000, 1, 1000, PartitionField(1, 1000, VoidTransform(),
"void_transform")
+ )
+
+
[email protected]
[email protected]("catalog",
[pytest.lazy_fixture("session_catalog_hive"),
pytest.lazy_fixture("session_catalog")])
+def test_add_void_generates_default_name(catalog: Catalog,
table_schema_simple: Schema) -> None:
+ simple_table = _create_table_with_schema(catalog, table_schema_simple, "1")
+ simple_table.update_spec().add_field("foo", VoidTransform()).commit()
+ _validate_new_partition_fields(
+ simple_table, 1000, 1, 1000, PartitionField(1, 1000, VoidTransform(),
"foo_null")
+ )
+
+
[email protected]
[email protected]("catalog",
[pytest.lazy_fixture("session_catalog_hive"),
pytest.lazy_fixture("session_catalog")])
+def test_add_truncate_generates_default_name(catalog: Catalog,
table_schema_simple: Schema) -> None:
Review Comment:
Thank you for catching that, removed it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
