aokolnychyi commented on code in PR #11044:
URL: https://github.com/apache/iceberg/pull/11044#discussion_r1757675900
##########
core/src/test/java/org/apache/iceberg/DataTableScanTestBase.java:
##########
@@ -180,12 +184,25 @@ public void testSettingInvalidRefFails() {
private void validateExpectedFileScanTasks(ScanT scan, List<CharSequence>
expectedFileScanPaths)
throws IOException {
+ validateExpectedFileScanTasks(scan, expectedFileScanPaths, null);
+ }
+
+ private void validateExpectedFileScanTasks(
+ ScanT scan,
+ Collection<CharSequence> expectedFileScanPaths,
+ Map<CharSequence, String> fileToManifest)
Review Comment:
I think this should be either `Map<String, String>` or `CharSequenceMap` to
be safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
