szehon-ho commented on code in PR #10981:
URL: https://github.com/apache/iceberg/pull/10981#discussion_r1755705776
##########
format/spec.md:
##########
@@ -190,6 +190,7 @@ Supported primitive types are defined in the table below.
Primitive types added
| | **`uuid`** | Universally unique identifiers
| Should use 16-byte fixed
|
| | **`fixed(L)`** | Fixed-length byte array of length L
|
|
| | **`binary`** | Arbitrary-length byte array
|
|
+| [v3](#version-3) | **`geometry(C, T, E)`** | An object of the simple feature
geometry model as defined by Appendix G; This may be any of the Geometry
subclasses defined therein; coordinate reference system C [4], coordinate
reference system type T [5], edges E [6] | C, T, E are fixed. Encoded as WKB,
see Appendix G. |
Review Comment:
Related to above comment, I think these will all be optional (take a default
value if not specified).
##########
format/spec.md:
##########
@@ -198,6 +199,9 @@ Notes:
- Timestamp values _with time zone_ represent a point in time: values are
stored as UTC and do not retain a source time zone (`2017-11-16 17:10:34 PST`
is stored/retrieved as `2017-11-17 01:10:34 UTC` and these values are
considered identical).
- Timestamp values _without time zone_ represent a date and time of day
regardless of zone: the time value is independent of zone adjustments
(`2017-11-16 17:10:34` is always retrieved as `2017-11-16 17:10:34`).
3. Character strings must be stored as UTF-8 encoded byte arrays.
+4. Coordinate Reference System, i.e. mapping of how coordinates refer to
precise locations on earth. Defaults to "OGC:CRS84". Fixed and cannot be
changed by schema evolution.
+5. Coordinate Reference System Type, value specifying type of Coordinate
Reference System field, if that is different from default. Defaults to empty
string. Fixed and cannot be changed by schema evolution.
+6. Edges, interpretation for edges within geometry object, i.e. whether the
edge between points represent a straight cartesian line or the shortest line on
the sphere. Please note that it only applies to polygons. Fixed and cannot be
changed by schema evolution.
Review Comment:
Done, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
