pvary commented on PR #11010: URL: https://github.com/apache/iceberg/pull/11010#issuecomment-2343218837
@stevenzwu: I didn't get answer for my question on the Flink dev list about the output of the PostCommitTopology. See: https://lists.apache.org/thread/28qb1q6b7kz30dqjdbsw855osx4t38s7 I created some unit test and checked that if we return `Void` the PostCommitTopology is executed. After some back-and-forth myself, I decided to move forward with the `Void` output as suggested by you. Mainly because of the `LockRemover` will be used in 2 cases: 1. `Post Commit Maintenance` - in this case the output could not be used 2. `Separate Maintenance Job` - in this case the output could be used to act upon failures, but it is unlikely and could be implemented if required later The `LockRemover` will not be used when `External scheduler` is used. Please share your thoughts, and review. Thanks, Peter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
