manuzhang commented on code in PR #10996:
URL: https://github.com/apache/iceberg/pull/10996#discussion_r1753036975
##########
mr/src/test/java/org/apache/iceberg/mr/hive/serde/objectinspector/TestIcebergObjectInspector.java:
##########
@@ -99,14 +98,9 @@ public void testIcebergObjectInspector() {
assertThat(dateField.getFieldID()).isEqualTo(3);
assertThat(dateField.getFieldName()).isEqualTo("date_field");
assertThat(dateField.getFieldComment()).isEqualTo("date comment");
- if (HiveVersion.min(HiveVersion.HIVE_3)) {
- assertThat(dateField.getFieldObjectInspector().getClass().getName())
- .isEqualTo(
-
"org.apache.iceberg.mr.hive.serde.objectinspector.IcebergDateObjectInspectorHive3");
- } else {
- assertThat(dateField.getFieldObjectInspector().getClass().getName())
-
.isEqualTo("org.apache.iceberg.mr.hive.serde.objectinspector.IcebergDateObjectInspector");
- }
+ assertThat(dateField.getFieldObjectInspector().getClass().getName())
+ .isEqualTo(
+
"org.apache.iceberg.mr.hive.serde.objectinspector.IcebergDateObjectInspectorHive");
Review Comment:
I removed iceberg-mr from tests when removing the hive2 tests. Now it's
added in hive3 tests while there are new test errors I need to fix. Thanks for
catching this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
