stevenzwu commented on code in PR #11086:
URL: https://github.com/apache/iceberg/pull/11086#discussion_r1749541033
##########
core/src/test/java/org/apache/iceberg/TestFastAppend.java:
##########
@@ -42,6 +42,25 @@ protected static List<Object> parameters() {
return Arrays.asList(1, 2, 3);
}
+ @TestTemplate
+ public void testAddManyFiles() {
+ assertThat(listManifestFiles()).as("Table should start empty").isEmpty();
+
+ List<DataFile> dataFiles = Lists.newArrayList();
+
+ for (int ordinal = 0; ordinal < 20_000; ordinal++) {
Review Comment:
I am usually good with package private. we have quite a bit
`@VisibleForTesting` for case like that.
It can be tricky to update the tests if we ever change the
`MIN_FILE_GROUP_SIZE` default value to some larger value like 20_000. then this
test is not covering the intended case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
