liurenjie1024 commented on code in PR #594:
URL: https://github.com/apache/iceberg-rust/pull/594#discussion_r1743337943
##########
crates/integrations/datafusion/src/physical_plan/scan.rs:
##########
@@ -138,3 +156,18 @@ async fn get_batch_stream(
Ok(Box::pin(stream))
}
+
+fn get_column_names(schema: ArrowSchemaRef, projection: Option<&Vec<usize>>)
-> Vec<String> {
Review Comment:
Why not return `None` when there is no projection? In this case we don't
need to construct the whole fields
##########
crates/integrations/datafusion/src/physical_plan/scan.rs:
##########
@@ -116,7 +125,11 @@ impl DisplayAs for IcebergTableScan {
_t: datafusion::physical_plan::DisplayFormatType,
f: &mut std::fmt::Formatter,
) -> std::fmt::Result {
- write!(f, "IcebergTableScan")
+ write!(
+ f,
+ "IcebergTableScan projection:[{}]",
+ self.projection.join(" ")
Review Comment:
```suggestion
self.projection.join(", ")
```
##########
crates/examples/src/datafusion_read_data.rs:
##########
Review Comment:
I would suggest to move this example to another pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
