findepi commented on issue #10855: URL: https://github.com/apache/iceberg/issues/10855#issuecomment-2325763757
thanks for your insights @danielhumanmod ! > there are several `DangerousJavaDeserialization` warning in our code, do we have a plan to do some investigation on that? There is a separate issue about this: https://github.com/apache/iceberg/issues/10853 > Currently, `ImmutablesReferenceEquality` is only triggered in line 119 of `BaseViewOpertaions.java` if this is the only place, then yes it makes sense to enable the check and just suppress in this place. And yes, it's intentional. > However, contributors should explain the necessity of the reference equality check, and all instances of @SuppressWarnings should be carefully reviewed during code reviews. @danielhumanmod good point. Suppression should be last resort and code-commented. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
