anigos commented on code in PR #11045: URL: https://github.com/apache/iceberg/pull/11045#discussion_r1739596762
########## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestCreateChangelogViewProcedure.java: ########## @@ -242,6 +249,34 @@ public void testUpdateWithIdentifierField() { sql("select * from %s order by _change_ordinal, id, data", viewName)); } + @TestTemplate + public void testUpdateWithInComparableType() { + createTableWithIncomparableType(); + + sql("INSERT INTO %s VALUES (2, Map('b','b'), 12)", tableName); + Table table = validationCatalog.loadTable(tableIdent); + Snapshot snap1 = table.currentSnapshot(); + + sql("INSERT OVERWRITE %s VALUES (3, Map('c','c'), 13), (2, Map('d','d'), 12)", tableName); Review Comment: Exactly what I thought. We can't skip the ordering for a specific column because any non key column are under DML consideration. It can impact the net changes outcome. @flyrain what you say? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org