danielcweeks commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1739340299
########## open-api/rest-catalog-open-api.py: ########## @@ -852,6 +881,29 @@ class ViewRequirement(BaseModel): __root__: AssertViewUUID = Field(..., discriminator='type') +class FailedPlanningResult(IcebergErrorResponse): + """ + Failed server-side planning result + """ + + status: Literal['failed'] + + +class AsyncPlanningResult(BaseModel): + status: Literal['submitted'] + plan_id: Optional[str] = Field( + None, alias='plan-id', description='ID used to track a planning request' + ) + + +class EmptyResult(BaseModel): Review Comment: ```suggestion class EmptyPlanningResult(BaseModel): ``` To be consistent with other results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org