hantangwangd commented on PR #10983:
URL: https://github.com/apache/iceberg/pull/10983#issuecomment-2317476054
Following the discussions above, I changed the approach to just ensure that
users will not fall into a state where they cleanup files that are still
referenced:
- If `expireSnapshotId` is called and `incrementalCleanup` is set
explicitly to `true`, we fail before triggering the file cleanup.
- If `expireSnapshotId` is called and `incrementalCleanup` isn't specified,
we set `incrementalCleanup` to `false` so that reachable cleanup will be used.
Please take a look when convenient, thanks a lot! @rdblue @amogh-jahagirdar
@RussellSpitzer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
