aokolnychyi commented on code in PR #10984:
URL: https://github.com/apache/iceberg/pull/10984#discussion_r1729615153
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java:
##########
@@ -851,18 +851,29 @@ private static void deleteManifests(FileIO io,
List<ManifestFile> manifests) {
.run(item -> io.deleteFile(item.path()));
}
+ public static Dataset<Row> loadTable(SparkSession spark, Table table, long
snapshotId) {
+ SparkTable sparkTable = new SparkTable(table, snapshotId, false);
+ DataSourceV2Relation relation = createRelation(sparkTable,
ImmutableMap.of());
+ return Dataset.ofRows(spark, relation);
+ }
+
public static Dataset<Row> loadMetadataTable(
SparkSession spark, Table table, MetadataTableType type) {
return loadMetadataTable(spark, table, type, ImmutableMap.of());
}
public static Dataset<Row> loadMetadataTable(
SparkSession spark, Table table, MetadataTableType type, Map<String,
String> extraOptions) {
- SparkTable metadataTable =
- new SparkTable(MetadataTableUtils.createMetadataTableInstance(table,
type), false);
+ Table metadataTable =
MetadataTableUtils.createMetadataTableInstance(table, type);
+ SparkTable sparkMetadataTable = new SparkTable(metadataTable, false);
+ DataSourceV2Relation relation = createRelation(sparkMetadataTable,
extraOptions);
+ return Dataset.ofRows(spark, relation);
+ }
+
+ private static DataSourceV2Relation createRelation(
+ SparkTable sparkTable, Map<String, String> extraOptions) {
CaseInsensitiveStringMap options = new
CaseInsensitiveStringMap(extraOptions);
- return Dataset.ofRows(
- spark, DataSourceV2Relation.create(metadataTable, Some.empty(),
Some.empty(), options));
+ return DataSourceV2Relation.create(sparkTable, Some.empty(), Some.empty(),
options);
Review Comment:
Switched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
