rdblue commented on code in PR #8062: URL: https://github.com/apache/iceberg/pull/8062#discussion_r1729564755
########## core/src/test/java/org/apache/iceberg/TestSnapshotManager.java: ########## @@ -115,11 +116,10 @@ public void testCherryPickDynamicOverwriteConflict() { long lastSnapshotId = table.currentSnapshot().snapshotId(); // pick the snapshot into the current state - AssertHelpers.assertThrows( - "Should reject partition replacement when a partition has been modified", Review Comment: @nastra, why was this merged when it drops the context from all of these assertions? We took the time to write these context strings that explain what the assertion is testing and I would expect them to be carried forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org