TiansuYu commented on code in PR #1083:
URL: https://github.com/apache/iceberg-python/pull/1083#discussion_r1726626714
##########
pyiceberg/table/__init__.py:
##########
@@ -2492,21 +2492,22 @@ def update_column(
except ResolveError as e:
raise ValidationError(f"Cannot change column type:
{full_name}: {field.field_type} -> {field_type}") from e
+ # if other updates for the same field exist in one transaction:
if updated := self._updates.get(field.field_id):
self._updates[field.field_id] = NestedField(
field_id=updated.field_id,
name=updated.name,
field_type=field_type or updated.field_type,
- doc=doc or updated.doc,
- required=updated.required,
+ doc=doc if doc is not None else updated.doc,
+ required=required or updated.required,
Review Comment:
@sungwy I have fixed this as well. let me know if this ignorance is intended
in the first place.
##########
pyiceberg/table/__init__.py:
##########
@@ -2492,21 +2492,22 @@ def update_column(
except ResolveError as e:
raise ValidationError(f"Cannot change column type:
{full_name}: {field.field_type} -> {field_type}") from e
+ # if other updates for the same field exist in one transaction:
if updated := self._updates.get(field.field_id):
self._updates[field.field_id] = NestedField(
field_id=updated.field_id,
name=updated.name,
field_type=field_type or updated.field_type,
- doc=doc or updated.doc,
- required=updated.required,
+ doc=doc if doc is not None else updated.doc,
+ required=required or updated.required,
Review Comment:
Let me know the original code is the intended behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
