amogh-jahagirdar commented on code in PR #10433:
URL: https://github.com/apache/iceberg/pull/10433#discussion_r1725991357
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3InputStream.java:
##########
@@ -139,7 +140,11 @@ private InputStream readRange(String range) {
S3RequestUtil.configureEncryption(s3FileIOProperties, requestBuilder);
- return s3.getObject(requestBuilder.build(),
ResponseTransformer.toInputStream());
+ stream =
+ RetryableInputStream.builderFor(
+ () -> s3.getObject(requestBuilder.build(),
ResponseTransformer.toInputStream()))
Review Comment:
I updated this, the RetryableInputStream offers two builder APIs, one for
specifying just a new stream initialization and one for a stream initialization
plus a position supplier. The stream initialization function takes in a
position (the position can be null to handle the range based requests since for
range reads with explicit begin/end we don't care about the current position in
the stream). cc @danielcweeks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
