stevenzwu commented on code in PR #10956:
URL: https://github.com/apache/iceberg/pull/10956#discussion_r1725705497
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceBoundedGenericRecord.java:
##########
@@ -69,12 +70,13 @@ public class TestIcebergSourceBoundedGenericRecord {
private static final HadoopCatalogExtension CATALOG_EXTENSION =
new HadoopCatalogExtension(TestFixtures.DATABASE, TestFixtures.TABLE);
- @Parameters(name = "format={0}, parallelism = {1}")
+ @Parameters(name = "format={0}, parallelism = {1}, useConverter = {2}")
public static Object[][] parameters() {
return new Object[][] {
- {FileFormat.AVRO, 2},
- {FileFormat.PARQUET, 2},
- {FileFormat.ORC, 2}
+ {FileFormat.AVRO, 2, false},
+ {FileFormat.PARQUET, 2, true},
+ {FileFormat.PARQUET, 2, false},
+ {FileFormat.ORC, 2, true}
Review Comment:
sounds good to me. will change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
