rdblue commented on code in PR #10948: URL: https://github.com/apache/iceberg/pull/10948#discussion_r1720345226
########## format/spec.md: ########## @@ -193,16 +204,14 @@ Supported primitive types are defined in the table below. Primitive types added Notes: -1. Decimal scale is fixed and cannot be changed by schema evolution. Precision can only be widened. Review Comment: This is cleanup to make things more consistent. For decimal type promotion specifically, I removed this so that the section on schema evolution and type promotion is the source of truth. There shouldn't be two places to update so when I saw this was duplicative, I thought I should address it. Similarly for timestamps, the type definition has the precision and there is no need to add it to the notes. I also clarified `time` for consistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
