zeroshade commented on code in PR #118:
URL: https://github.com/apache/iceberg-go/pull/118#discussion_r1719993344


##########
literals.go:
##########
@@ -71,6 +71,12 @@ type TypedLiteral[T LiteralType] interface {
        Comparator() Comparator[T]
 }
 
+type NumericLiteral interface {

Review Comment:
   It's used with the transforms, specifically for `truncateNumber`.
   
   Looking through this, I could probably change this to not be exported though 
if we want.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to