emkornfield commented on code in PR #10948: URL: https://github.com/apache/iceberg/pull/10948#discussion_r1719268387
########## format/spec.md: ########## @@ -1308,7 +1321,7 @@ Default values are added to struct fields in v3. Types `timestamp_ns` and `timestamptz_ns` are added in v3. -All readers are required to read tables with unknown partition transforms, ignoring them. +All readers are required to read tables with unknown partition transforms, ignoring the unsupported partition fields. Review Comment: we might want to clarify this meaning in the case of matching delete files with data files, the partition values can't be ignored we just need to use the empirical schema for the types from the manifest files? I'm also not sure if there is an impact of partition statistics (reading quickly it doesn't look like there is any)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
