sungwy commented on code in PR #817: URL: https://github.com/apache/iceberg-python/pull/817#discussion_r1719107560
########## pyiceberg/catalog/__init__.py: ########## @@ -537,6 +537,22 @@ def list_namespaces(self, namespace: Union[str, Identifier] = ()) -> List[Identi NoSuchNamespaceError: If a namespace with the given name does not exist. """ + @abstractmethod + def list_views(self, namespace: Union[str, Identifier]) -> List[Identifier]: + """List views under the given namespace in the catalog. + + If namespace not provided, will list all views in the catalog. Review Comment: nit: ```suggestion If namespace is not provided, lists all views in the catalog. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org