dimas-b commented on code in PR #10908: URL: https://github.com/apache/iceberg/pull/10908#discussion_r1719071732
########## open-api/src/test/java/org/apache/iceberg/rest/RESTCompatibilityKitCatalogTests.java: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.rest; + +import org.apache.iceberg.catalog.CatalogTests; +import org.apache.iceberg.util.PropertyUtil; +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.BeforeEach; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class RESTCompatibilityKitCatalogTests extends CatalogTests<RESTCatalog> { + private static final Logger LOG = LoggerFactory.getLogger(RESTCompatibilityKitCatalogTests.class); + + private static RESTCatalog restCatalog; + + @BeforeAll + static void beforeClass() throws Exception { + if (RCKUtils.isLocalServer()) { + RCKUtils.startLocalServer(); Review Comment: With extensions, I'd usually have it inject (as a JUnit5 `ParameterResolver`) some java object (e.g. `URI`) or config into test classes for them to use in creating the REST Catalog (client)... Pseudo-code for example: ``` static void beforeClass(@RESTServerURI URI uri, @RCKConfig Map<String, String> config) throws Exception { restCatalog = RCKUtils.initCatalogClient(uri, config); } ``` `@RESTServerURI` would be defined in the TCK. Non-default test extension will be responsible for injecting it for whatever custom server impl. The URI can be part of the config, of course. The code that uses `@RESTServerURI` and `@RCKConfig` does not have to depend on test extensions. For example, RCK logic is in class `RESTCompatibilitySuite` (abstract, for reuse) - no references to system props, env, or `RESTServerCatalogAdapter`. Then: ``` @ExtendWith(RESTServerExtension.class) class RESTCompatibilityReferenceTest extends RESTCompatibilitySuite { // this class is empty and NOT REUSED outside of the Iceberg repo } ``` Loading config from system props and env is handled by `RESTServerExtension`, which also injects config into `RESTCompatibilitySuite`. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
