amogh-jahagirdar commented on code in PR #10945:
URL: https://github.com/apache/iceberg/pull/10945#discussion_r1718965043
##########
aws/src/test/java/org/apache/iceberg/aws/s3/signer/TestS3RestSigner.java:
##########
@@ -171,12 +171,8 @@ private static Server initHttpServer() throws Exception {
new S3SignerServlet(S3ObjectMapper.mapper(),
ImmutableList.of(deleteObjectsWithBody));
ServletContextHandler servletContext =
new ServletContextHandler(ServletContextHandler.NO_SESSIONS);
- servletContext.setContextPath("/");
- ServletHolder servletHolder = new ServletHolder(servlet);
- servletHolder.setInitParameter("javax.ws.rs.Application",
"ServiceListPublic");
- servletContext.addServlet(servletHolder, "/*");
- servletContext.setVirtualHosts(null);
- servletContext.setGzipHandler(new GzipHandler());
+ servletContext.addServlet(new ServletHolder(servlet), "/*");
+ servletContext.setHandler(new GzipHandler());
Review Comment:
Yeah I realized setting the Gzip handler is important, I thought it was
already done by default but apparently not!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
