pvary commented on code in PR #10179:
URL: https://github.com/apache/iceberg/pull/10179#discussion_r1718169335
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkV2Base.java:
##########
@@ -362,7 +362,7 @@ protected Record record(int id, String data) {
return SimpleDataUtil.createRecord(id, data);
}
- private List<Snapshot> findValidSnapshots() {
+ protected List<Snapshot> findValidSnapshots() {
Review Comment:
nit: could this be package private?
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkV2Base.java:
##########
@@ -373,11 +373,11 @@ private List<Snapshot> findValidSnapshots() {
return validSnapshots;
}
- private StructLikeSet expectedRowSet(Record... records) {
+ protected StructLikeSet expectedRowSet(Record... records) {
Review Comment:
nit: could this be package private?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
