pvary commented on code in PR #10179:
URL: https://github.com/apache/iceberg/pull/10179#discussion_r1718098952
##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkManifestUtil.java:
##########
@@ -129,4 +133,25 @@ static WriteResult readCompletedFiles(
return
builder.addReferencedDataFiles(deltaManifests.referencedDataFiles()).build();
}
+
+ public static void deleteCommittedManifests(
+ Table table, List<ManifestFile> manifests, String newFlinkJobId, long
checkpointId) {
+ for (ManifestFile manifest : manifests) {
+ try {
+ table.io().deleteFile(manifest.path());
+ } catch (Exception e) {
+ // The flink manifests cleaning failure shouldn't abort the completed
checkpoint.
+ String details =
+ MoreObjects.toStringHelper(FlinkManifestUtil.class)
+ .add("flinkJobId", newFlinkJobId)
+ .add("checkpointId", checkpointId)
+ .add("manifestPath", manifest.path())
+ .toString();
Review Comment:
This seems a bit strange way for me to collect the parameters for the log
line.
Minimally we need to add the tableName to the log line too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
